Make and generate_code.sh generate same outputs #6855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaileychess
force-pushed
the
generated_files
branch
from
12603e2
to
47e8f8b
Compare
|
LGTM! Sorry for introducing the bug. Can you add a line in |
|
@CasperN Added the checks. |
|
Ha, it already caught an error |
|
@CasperN There are some oddities with the legacy microsoft build that I didn't want to hold up. So I just added the checks to the linux scripts/check-generated-code.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6843
There were some differences between the arguments in the CMakeLists.txt file and test/generate_code.sh scripts that made modified files after a clean build.
The discrepancy occurred in #6613