Add out_sharding argument to call methods for layers with jax calls that support it#5102
Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom Dec 11, 2025
Merged
Conversation
samanklesaria
force-pushed
the
output_sharding
branch
2 times, most recently
from
1195087 to
96f0a64
Compare
samanklesaria
force-pushed
the
output_sharding
branch
from
96f0a64 to
1f61d6b
Compare
samanklesaria
changed the title
cgarciae
reviewed
Nov 25, 2025
tests/nnx/spmd_test.py
Outdated
| with jax.set_mesh(mesh): | ||
| replicated_array = jnp.arange(4).reshape(2, 2) | ||
| sharded_array = reshard(replicated_array, P("X", None)) | ||
| l = nnx.Linear(2,4, rngs=nnx.Rngs(0)) |
cgarciae
approved these changes
Nov 25, 2025
chapman20j
reviewed
Nov 25, 2025
flax/nnx/nn/linear.py
Outdated
Comment on lines
+415
to
+416
| dot_general_kwargs = {} | ||
| dot_general_kwargs['out_sharding'] = out_sharding |
Collaborator
There was a problem hiding this comment.
Can we update this to be done in one line?
chapman20j
approved these changes
Dec 11, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
output_shardingto standard layers just like in jax for use with explicit sharding.