Skip to content

[flax:examples:ppo] Fix some linter / import issues. #jax-fixit #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 3, 2025
Merged

[flax:examples:ppo] Fix some linter / import issues. #jax-fixit #5120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/ppo/seed_rl_atari_preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
"""

import cv2
from gymnasium.spaces.box import Box
import gymnasium as gym
from gymnasium.spaces.box import Box
import numpy as np


Expand Down Expand Up @@ -117,7 +117,7 @@ def action_space(self):

@property
def reward_range(self):
return self.environment.reward_range
return self.environment.reward_range # type: ignore

@property
def metadata(self):
Expand Down Expand Up @@ -189,7 +189,7 @@ def step(self, action):
# We bypass the Gym observation altogether and directly fetch the
# grayscale image from the ALE. This is a little faster.
_, reward, game_over, _, info = self.environment.step(action)
accumulated_reward += reward
accumulated_reward += float(reward)

if self.terminal_on_life_loss:
new_lives = self.environment.unwrapped.ale.lives() # pytype:disable=attribute-error
Expand Down
Loading