Avoid passing concrete argument to jax.remat
#5121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_839319133
branch
4 times, most recently
from
81d8c6d to
8a22461
Compare
This argument has had no effect since JAX v0.3.17, aside from raising `NotImplementedError` if it is set to `True`. It will be deprecated in JAX v0.8.2 and eventually removed (jax-ml/jax#33674). Flax should probably deprecate this argument from its own `remat` wrappers, but I'll leave that up to the team. #jax-fixit PiperOrigin-RevId: 840353856
copybara-service
bot
force-pushed
the
test_839319133
branch
from
8a22461 to
ec85cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid passing
concreteargument tojax.rematThis argument has had no effect since JAX v0.3.17, aside from raising
NotImplementedErrorif it is set toTrue. It will be deprecated in JAX v0.8.2 and eventually removed (jax-ml/jax#33674).Flax should probably deprecate this argument from its own
rematwrappers, but I'll leave that up to the team.#jax-fixit