Fix off by one issue in edge embedding table size #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs some cleanup before it's ready for review. |
ondrasej
requested changes
Apr 10, 2024
|
Ready for review now as the underlying issue has been fixed. This would still benefit from test coverage, but some changes to the test infrastructure need to be made to pull in the appropriate block. Going to work on that in a future PR that I'll open up soon. |
|
Test infrastructure was simpler than I thought. The test is included in this patch. |
ondrasej
requested changes
Jul 5, 2024
ondrasej
reviewed
Jul 9, 2024
ondrasej
approved these changes
Jul 9, 2024
virajbshah
pushed a commit
to virajbshah/gematria
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108