Add sanitizer configs to bazel #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds sanitizer configs to .bazelrc so a developer can simply use --config=asan or --config=tsan on a specific test to see if there are any issues. It seems like asan might be catching some issues I will have to look into this in a bit.
ondrasej
approved these changes
Jun 26, 2024
Right. This was mostly intended for looking at dataset processing things that don't have to do anything low-level (i.e., not benchmarking this case). The motivating example as #101 with the question of whether or not we need a per-thread |
virajbshah
pushed a commit
to virajbshah/gematria
that referenced
this pull request
Jul 17, 2024
This patch adds sanitizer configs to .bazelrc so a developer can simply use --config=asan or --config=tsan on a specific test to see if there are any issues. It seems like asan might be catching some issues I will have to look into this in a bit.
virajbshah
pushed a commit
to virajbshah/gematria
that referenced
this pull request
Jul 24, 2024
This patch adds sanitizer configs to .bazelrc so a developer can simply use --config=asan or --config=tsan on a specific test to see if there are any issues. It seems like asan might be catching some issues I will have to look into this in a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds sanitizer configs to .bazelrc so a developer can simply use --config=asan or --config=tsan on a specific test to see if there are any issues. It seems like asan might be catching some issues I will have to look into this in a bit.