Skip to content

Commit

Permalink
comment: Prevent adding new features to symbolize detection via the
Browse files Browse the repository at this point in the history
preprocessor.

According to sergiud, glog project have made a decision moving away
from using preprocessor logic. Add a comment to prevent people get
confused.
  • Loading branch information
hcoona committed Jul 31, 2024
1 parent e3fa33d commit 456c75b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/symbolize.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@
# error "symbolize.h" was not included correctly.
#endif

// INFO(sergiud): Add new features to build system instead of here.
// See GitHub pull request !1114 for a detail discussion.
#ifndef GLOG_NO_SYMBOLIZE_DETECTION
# ifndef HAVE_SYMBOLIZE
// defined by gcc
Expand Down

0 comments on commit 456c75b

Please sign in to comment.