Skip to content

support mutating scratch images#1882

Closed
jordan-da wants to merge 1 commit intogoogle:mainfrom
jordan-da:main
Closed

support mutating scratch images#1882
jordan-da wants to merge 1 commit intogoogle:mainfrom
jordan-da:main

Conversation

@jordan-da
Copy link

closes #1881

Adds support for mutating scratch base images.

@google-cla
Copy link

google-cla bot commented Feb 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@jordan-da
Copy link
Author

Is it possible to get some eyes on this, I don't mind it if takes longer to review but I would hate for it to be closed out of it going stale

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@jordan-da
Copy link
Author

Is this project not considering external contributions at this time?

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@mepi262
Copy link

mepi262 commented Dec 30, 2024

@jordan-da
It seems that some checks are not working.
Would you try the following action?
https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

@jordan-da
Copy link
Author

It seems that some checks are not working.

sure

@jordan-da
Copy link
Author

@jordan-da It seems that some checks are not working. Would you try the following action? https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

blehhh... I accidentally pushed origin to my fork, which automatically closed the pr : /

I fixed the merge conflicts and rebased, I guess i need another approval now cc @martianoff

Sorry for the mess folks

@jordan-da
Copy link
Author

jordan-da commented Jan 3, 2025

@jordan-da It seems that some checks are not working. Would you try the following action? https://stackoverflow.com/questions/52200096/github-pull-request-waiting-for-status-to-be-reported

@mepi262 i followed the steps in the post, force pushed an amended commit, these checks are still stuck.. do they require a lifecycle phase change?

@jordan-da jordan-da closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

question: append with an empty base and environment vars?

4 participants