Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod: upgrade to latest go #2008

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

go mod: upgrade to latest go #2008

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8263ab7
style: upgrade to latest go
imjasonh Sep 11, 2024
0026c74
Update go.mod
imjasonh Sep 11, 2024
65bee90
Update style.yaml
imjasonh Sep 11, 2024
1bf1743
Update bump-deps.yaml
imjasonh Sep 11, 2024
8ea202e
Update ghcr-auth.yaml
imjasonh Sep 11, 2024
6322b11
Update e2e.yaml
imjasonh Sep 11, 2024
30d9871
some more
imjasonh Sep 11, 2024
0ccaaed
boilerplate
imjasonh Sep 11, 2024
a58361f
all the mods
imjasonh Sep 11, 2024
1cb5f47
Update e2e.yaml
imjasonh Sep 11, 2024
2eb855f
Update .github/workflows/e2e.yaml
jonjohnsonjr Sep 11, 2024
c4bda89
Update go.mod
jonjohnsonjr Sep 11, 2024
020a5d8
Update pkg/authn/kubernetes/go.mod
jonjohnsonjr Sep 11, 2024
b2cfd86
Update pkg/authn/k8schain/go.mod
jonjohnsonjr Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/boilerplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Check out code
uses: actions/checkout@v3

- uses: chainguard-dev/actions/boilerplate@5e21cb47971231c078a677dfe89a348371cb880c # main
- uses: chainguard-dev/actions/boilerplate@29fb6e979a0b3efc79748a17e8cec08d0594cbfd # main
with:
extension: ${{ matrix.extension }}
language: ${{ matrix.language }}
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
go-version: [1.19, '1.20']
go-version: ['1.22', '1.23']

steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/bump-deps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- run: ./hack/bump-deps.sh
- name: Create Pull Request
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- name: crane append to an image, set the entrypoint, run it locally, roundtrip it
shell: bash
run: |
set -euxo pipefail

# Setup local registry
# Setup local registry, wait a bit for it to come up.
go run ./cmd/registry &
sleep 1
jonjohnsonjr marked this conversation as resolved.
Show resolved Hide resolved

base=alpine
platform=linux/amd64
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/ecr-auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- name: Install krane
working-directory: ./cmd/krane
Expand Down Expand Up @@ -61,8 +60,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- name: Install crane
working-directory: ./cmd/crane
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ghcr-auth.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- name: Install krane
working-directory: ./cmd/krane
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod
- run: ./hack/presubmit.sh
8 changes: 3 additions & 5 deletions .github/workflows/style.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ jobs:
name: check goimports
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
- uses: actions/checkout@v3
go-version-file: go.mod
- uses: chainguard-dev/actions/goimports@5e21cb47971231c078a677dfe89a348371cb880c # main

lint:
Expand All @@ -25,8 +24,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
check-latest: true
go-version-file: go.mod

- uses: golangci/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
test:
strategy:
matrix:
go-version: [1.19, '1.20']
go-version: ['1.22', '1.23']

name: Unit Tests
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion cmd/krane/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/go-containerregistry/cmd/krane

go 1.18
go 1.23.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other go.mod files dropped the patch version, is this file meant to still have them?


replace github.com/google/go-containerregistry => ../../

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/go-containerregistry

go 1.18
go 1.23.1
jonjohnsonjr marked this conversation as resolved.
Show resolved Hide resolved

require (
github.com/containerd/stargz-snapshotter/estargz v0.14.3
Expand Down
2 changes: 1 addition & 1 deletion pkg/authn/k8schain/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/go-containerregistry/pkg/authn/k8schain

go 1.18
go 1.23.1
jonjohnsonjr marked this conversation as resolved.
Show resolved Hide resolved

replace (
github.com/google/go-containerregistry => ../../../
Expand Down
2 changes: 1 addition & 1 deletion pkg/authn/kubernetes/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/google/go-containerregistry/pkg/authn/kubernetes

go 1.18
go 1.23.1
jonjohnsonjr marked this conversation as resolved.
Show resolved Hide resolved

replace github.com/google/go-containerregistry => ../../../

Expand Down
Loading