Skip to content

Add CancelInvite method to cancel an org invitation by ID #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

DocEmmetBrown
Copy link
Contributor

The https://docs.github.com/en/rest/orgs/members?apiVersion=2022-11-28#cancel-an-organization-invitation endpoint was not available, and I needed it for some tooling.

I tried my best to stick to the standards, and added a quick test.
Happy to update / change anything if required.

Copy link

google-cla bot commented Sep 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (2b8c7fa) to head (80e3056).
Report is 124 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
- Coverage   97.72%   92.97%   -4.75%     
==========================================
  Files         153      171      +18     
  Lines       13390    11721    -1669     
==========================================
- Hits        13085    10898    -2187     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown !
One minor tweak to address, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo (plus the signed CLA) before merging.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the errors locally by reading step 4 in CONTRIBUTING.md
and sign the CLA, then we can move forward with this PR.

@DocEmmetBrown DocEmmetBrown force-pushed the feat/revoke-org-invites branch from 60063be to 033442e Compare September 14, 2024 16:53
@DocEmmetBrown
Copy link
Contributor Author

Please fix the errors locally by reading step 4 in CONTRIBUTING.md and sign the CLA, then we can move forward with this PR.

I ran the scripts, and everything should be OK now.
Regarding the CLA, I'm waiting for a response from within my company, I should have it early next week, and will sign it then.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 14, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown !
LGTM.

Awaiting signed CLA, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@DocEmmetBrown
Copy link
Contributor Author

@gmlewis : CCLA has finally been signed for the whole aiven.io organization, but the action doesn't seem to find it. Anything I can do to unblock the situation ?

@DocEmmetBrown DocEmmetBrown force-pushed the feat/revoke-org-invites branch from 2233f7b to 8bad333 Compare September 23, 2024 10:20
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2024

Anything I can do to unblock the situation ?

It looks like 3 emails were found for this PR. You need to make sure that only the email that is part of the signed CLA is on this PR.

If you click on the "Details" link, it says this:

The following contributors were found for this pull request:

8bad333 Author: @DocEmmetBrown <gu.....me​@winter.digital>, <guil........nter​@aiven.io>, <DocEmmetBrown​ @users.noreply.github.com>

(Only the first commit for a unique contributor is listed.)

So you can either fix all the commits and force-push to this PR,
or you can simply close this PR and create a new one with only the one email address that has signed the CLA.

@DocEmmetBrown DocEmmetBrown force-pushed the feat/revoke-org-invites branch from 8bad333 to 2c4880f Compare September 23, 2024 11:13
@DocEmmetBrown
Copy link
Contributor Author

After a lot of internal shenanigans, it looks like the CLA approval is now being properly reported 🥳
@gmlewis: feel free to merge if everything else is OK for you

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DocEmmetBrown !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@andygrunwald andygrunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good. Thanks @DocEmmetBrown.

@gmlewis I hope this review helps you with this PR.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 26, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 26, 2024

Thank you, @andygrunwald !
Merging.

@gmlewis gmlewis merged commit dea28a3 into google:master Sep 26, 2024
6 of 7 checks passed
@DocEmmetBrown DocEmmetBrown deleted the feat/revoke-org-invites branch October 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants