Allow DOCKER_FORCE_PUSH for test images. #11180
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
The push-* command skips rebuild and image push w/ `latest` tag when a image tag exists remotely. Most of gVisor test images have never got a chance to be tagged because they already exist when `DOCKER_PUSH_AS_LATEST` was introduced. We shouldn't enable DOCKER_FORCE_PUSH in our pipelines, it is better to be a one off tool when the `latest` tag of an image is missing from remote repos. PiperOrigin-RevId: 696823576
copybara-service
bot
force-pushed
the
test/cl696573253
branch
from
c43a286
to
39a6242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow DOCKER_FORCE_PUSH for test images.
The push-* command skips rebuild and image push w/
latesttag when a imagetag exists remotely. Most of gVisor test images have never got a chance to be
tagged because they already exist when
DOCKER_PUSH_AS_LATESTwas introduced.We shouldn't enable DOCKER_FORCE_PUSH in our pipelines, it is better to be a
one off tool when the
latesttag of an image is missing from remote repos.