Netstack s/r: Configure the new network config in the loaded stack.#11389
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Netstack s/r: Configure the new network config in the loaded stack.#11389copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test/cl719364530
branch
9 times, most recently
from
cc3cd9b to
8bddb44
Compare
copybara-service
bot
changed the title
- Refactor the scrapping of network config in {sandbox/boot}/network.go to
make is easy to configure in the loaded stack during restore.
- Remove ReplaceConfig at the inet.Stack level.
- Restore some fields correctly in tcpip.Stack.
- Store the required network config in the loader and use it to set new
configuration in the loaded stack during restore.
This CL doesn't change any behavior when netstack s/r is disabled.
When netstack s/r is enabled:
- the network configuration will be applied to the loaded stack from the spec
instead of using the newly created stack.
- Previously the network config was applied to the new network stack and then
copied to the loaded stack in the ReplaceConfig method. Now, the network config
is directly applied to the loaded stack with the exception when XDP is enabled.
PiperOrigin-RevId: 719364530
copybara-service
bot
force-pushed
the
test/cl719364530
branch
from
8bddb44 to
1f544bd
Compare
|
A friendly reminder that this PR had no activity for 120 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netstack s/r: Configure the new network config in the loaded stack.
make is easy to configure in the loaded stack during restore.
configuration in the loaded stack during restore.
This CL doesn't change any behavior when netstack s/r is disabled.
When netstack s/r is enabled:
instead of using the newly created stack.
copied to the loaded stack in the ReplaceConfig method. Now, the network config
is directly applied to the loaded stack with the exception when XDP is enabled.