Open
Conversation
copybara-service
bot
force-pushed
the
test/cl766391911
branch
from
14fac3f to
fe559e3
Compare
Refactored tcpip/nftables/ and its contents to exist under tcpip/stack/ in
anticipation of implementing netlink netfilter sockets. These sockets need to
reference the system-wide nftables structure, which requires exposing it to all
processes.
The refactoring was necessary due to circular dependencies between the nftables
package and the stack package.
nftables/nftables.go was split up accordingly to more easily manage its types
(nftables_types.go) and the byte operations within it (see nft_{op}.go files).
NOTE: Files that previously existed under the nftables package are still not
thread safe. Future changes will add synchronization primitives to resolve this
issue.
PiperOrigin-RevId: 766391911
copybara-service
bot
force-pushed
the
test/cl766391911
branch
from
fe559e3 to
fadc468
Compare
|
A friendly reminder that this PR had no activity for 120 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring nftables package
Refactored tcpip/nftables/ and its contents to exist under tcpip/stack/ in
anticipation of implementing netlink netfilter sockets. These sockets need to
reference the system-wide nftables structure, which requires exposing it to all
processes.
The refactoring was necessary due to circular dependencies between the nftables
package and the stack package.
nftables/nftables.go was split up accordingly to more easily manage its types
(nftables_types.go) and the byte operations within it (see nft_{op}.go files).
NOTE: Files that previously existed under the nftables package are still not
thread safe. Future changes will add synchronization primitives to resolve this
issue.