bug: [checklocks] resolve iter on func #12412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the normal closure logic for the inter on func special closures
ayushr2
reviewed
Dec 27, 2025
Collaborator
ayushr2
left a comment
ayushr2
left a comment
There was a problem hiding this comment.
Thanks for your patch and for also adding tests!
| // their parent. We expect the same locks held on exit as | ||
| // on entry - any locks acquired in the closure should be | ||
| // released before yielding. | ||
| if rls.count() != parent.count() { |
Collaborator
There was a problem hiding this comment.
Is it theoretically possible that the closure acquires a new lock and while unlocking an old lock, making the count equal? Should we be using !rls.isCompatible(parent) here?
Contributor
Author
There was a problem hiding this comment.
Yes, I think it's possible. I will change it and check the tests.
The problem with testing this failures is that I won't get line number and thus the "standard" test machinery (+checkfailure) doesn't really work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the normal closure logic for the inter on func special closures
fixes #12176