-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Go to 1.25.5 #12427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go to 1.25.5 #12427
Conversation
ab636fe to
0e9ff5c
Compare
336dc29 to
c9d2c57
Compare
tamird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tools/build_cover.sh
Outdated
| go_version=1.25.5 | ||
| go_base_url=https://dl.google.com/go/ | ||
| arch="$(uname -m)" | ||
| case "$arch" in | ||
| x86_64) go_arch="amd64" ;; | ||
| aarch64) go_arch="arm64" ;; | ||
| *) echo "Unsupported architecture: $arch" >&2; exit 1 ;; | ||
| esac | ||
| go_filename="go${go_version}.linux-${go_arch}.tar.gz" | ||
| go_url="${go_base_url}${go_filename}" | ||
| mkdir go-bootstrap | ||
| curl -sSL "${go_url}" | tar -xz -C go-bootstrap | ||
| GOROOT_BOOTSTRAP="$(pwd)/go-bootstrap/go" | ||
| export GOROOT_BOOTSTRAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avagin how come all this is needed? shall I add a commit to my PR so that we have something in the history explaining it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr removes golang from the default image, but here a custom golang is compiled and this process requires a "bootstrap" compiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for explaining. I pulled this into my PR, could we keep the diff between this and that small please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also moved it to the proper commit and updated the message.
27adedb to
42fddb2
Compare
I reverted it. Let's do that in another pr, otherwise we will never merged this one. |
42fddb2 to
17c7e8b
Compare
Since we're still hitting failures, I sent this as a separate change in #12458. |
ee6d277 to
998b441
Compare
998b441 to
a35e9e8
Compare
Update Go to 1.25.5
checkescape: improve error output
The output now includes stderr on failure e.g.:
Simplify various bits of the implementation while I'm here:
CommandContextto ensure proper cleanup.Stderrto abytes.Buffer.bufio.Scannerinstead of manually calling(*bufio.Reader).ReadStringand handling errors.NextLineloop label.go_stateify: plumb go binary to goimports
This avoids go_stateify relying on
gobeing available outside of thebazel sandbox.
Update Go to 1.25.5
Reduce duplication of the version information in various places:
go_sdk.from_fileinstead of repeating the version encoded ingo.modinMODULE.bazel.Add a workaround to allow
objdumpto be lazily compiled in the mannerintroduced in https://go.dev/issue/71867 when invoked under bazel in
checkescape.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#12452 from tamird:update-go 6c7f640