syscalls: beef up write(2) and pwrite(2) tests #12438
Open
+403
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test/cl852782177
branch
5 times, most recently
from
9078452 to
1bd22af
Compare
Fixes #2370 Add comprehensive tests for write(2), pwrite(2), and writev(2) syscalls to improve coverage as requested in the issue. New tests include: - Bad buffer states (EFAULT): nullptr buffer, bad iov_base address - Bad file descriptors (EBADF): closed fd, negative fd, read-only fd, O_PATH fd - Offset behavior: verify offset increments, pwrite doesn't change offset - EOF handling: write extends past EOF, pwrite creates holes - Pipes: write to pipe, pwrite returns ESPIPE, write to read end fails - Symlinks: write through symlink, O_NOFOLLOW returns ELOOP - Special files: /dev/null and /dev/zero - writev edge cases: empty iovec, zero-length entries Also adds similar tests to `pwrite64.cc` for consistency. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12426 from 0xzre:write-syscall-tests 4f4666f PiperOrigin-RevId: 852782177
copybara-service
bot
force-pushed
the
test/cl852782177
branch
from
1bd22af to
34afac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscalls: beef up write(2) and pwrite(2) tests
Fixes #2370
Add comprehensive tests for write(2), pwrite(2), and writev(2) syscalls
to improve coverage as requested in the issue.
New tests include:
Also adds similar tests to
pwrite64.ccfor consistency.FUTURE_COPYBARA_INTEGRATE_REVIEW=#12426 from 0xzre:write-syscall-tests 4f4666f