checklocks: enforce mixed atomic rules for wrappers #12451
Merged
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ayushr2 PTAL |
ayushr2
approved these changes
Jan 7, 2026
ayushr2
reviewed
Jan 7, 2026
Atomic wrapper methods now respect mixed atomic+lock rules so lock-free access is read-only and writes require the lock. The README documents the wrapper behavior and tests cover the new cases.
tamird
force-pushed
the
checklocks-mixed-atomic
branch
from
f46e6b9 to
5c3aa23
Compare
ayushr2
approved these changes
Jan 7, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
Atomic wrapper methods now respect mixed atomic+lock rules so lock-free access is read-only and writes require the lock. The README documents the wrapper behavior and tests cover the new cases. Closes #11481. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12451 from tamird:checklocks-mixed-atomic 5c3aa23 PiperOrigin-RevId: 853306091
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Atomic wrapper methods now respect mixed atomic+lock rules so lock-free access is read-only and writes require the lock. The README documents the wrapper behavior and tests cover the new cases. Closes #11481. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12451 from tamird:checklocks-mixed-atomic 5c3aa23 PiperOrigin-RevId: 853306091
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Atomic wrapper methods now respect mixed atomic+lock rules so lock-free access is read-only and writes require the lock. The README documents the wrapper behavior and tests cover the new cases. Closes #11481. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12451 from tamird:checklocks-mixed-atomic 5c3aa23 PiperOrigin-RevId: 853306091
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atomic wrapper methods now respect mixed atomic+lock rules so lock-free
access is read-only and writes require the lock. The README documents
the wrapper behavior and tests cover the new cases.
Closes #11481.