demo: add AES demo for tfhe_rust CPU #1765
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <[email protected]> fix sbox timeout Signed-off-by: Asra Ali <[email protected]> remove test files Signed-off-by: Asra Ali <[email protected]> address comments Signed-off-by: Asra Ali <[email protected]> remove unneeded deps Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
Signed-off-by: Asra Ali <[email protected]>
|
Looks good to me |
|
Oh, you could also remove the rust-specific step from the ci workflow now |
|
@j2kun removing the CI step is handled in https://github.com/google/heir/pull/1743/files This PR depends on it! That PR is awaiting one more internal update :/ :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
The sbox takes quite a bit of time, so I'll update that, but at least it's working?
Depends on #1743