Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations and version bump #32

Closed
wants to merge 6 commits into from

Conversation

newtondev
Copy link

Currently using this project on a cluster and looking to invest more time into it and deploy it to more of our clusters. Did a bit of code discovery and review and spotted a few deprecations to fix which are included in this PR. Also using the latest Kubernetes so did a version bump on the dependencies.

I hope all is in order and that you will consider my PR.

Thank you

@halvards halvards self-assigned this Oct 2, 2024
@halvards
Copy link
Member

halvards commented Oct 2, 2024

Thanks for your contribution @newtondev! This appears to be a subset of PR #33. We could either:

  1. Merge this first, once the comment above has been resolved, or
  2. Close this PR and just merge Implement --platform parameter #33 once those comments have been resolved.

I'd be fine with either - so I'll leave the decision to you.

@halvards halvards assigned newtondev and unassigned halvards Oct 2, 2024
@newtondev
Copy link
Author

Hi @halvards , thanks for the comment. I believe option 2 to close this MR and merge the #33 would be fine. thanks.

@newtondev newtondev closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants