Skip to content

Fix memory leak in lf.coding.run. #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix memory leak in lf.coding.run. #237

merged 1 commit into from
Jul 3, 2024

Conversation

copybara-service[bot]
Copy link

Fix memory leak in lf.coding.run.

Process.terminate sends SIGTERM to the subprocess for graceful shutdown, which will wait the process to release its own resource. However, for code that has infinite loops, SIGTERM cannot end the process as desired. Instead SIGKILL will do the work for us.

`Process.terminate` sends SIGTERM to the subprocess for graceful shutdown, which will wait the process to release its own resource. However, for code that has infinite loops, SIGTERM cannot end the process as desired. Instead SIGKILL will do the work for us.

PiperOrigin-RevId: 649154566
@copybara-service copybara-service bot merged commit 75506b9 into main Jul 3, 2024
@copybara-service copybara-service bot deleted the test_649151622 branch July 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant