This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 118
feat/backup #64
Open
karchx
wants to merge
13
commits into
google:main
Choose a base branch
from
karchx:feat/backup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat/backup #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
reviewed
Jun 28, 2022
@ericchiang |
ericchiang
reviewed
Jun 29, 2022
Thanks! mostly just a comment about creating a new directory vs not |
Done |
ericchiang
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! two nits
also, can you please squash your commits? |
@ericchiang I was squashing commits and the PR seemed to be closed |
It looks like you've got some conflicts? If you need to open a new PR feel free, or I can pull in the changes myself. |
If it's not too much of a problem, I'll leave it to you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JARs backup at the time of running the inspection on the jar files, either a scan or with the --rewrite command, for example
the copy of the JARs is saved in
backup/*.jar
This may solve the issues:
Any improvement will be a pleasure to carry it out