-
Notifications
You must be signed in to change notification settings - Fork 45
chore: fix typos across codebase #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes incorrect fix (twice) for typo
Thanks, sir. |
Thank you for these fixes. Embarrassing that we didn't run a spellcheck. Can both of you please sign the CLA in comment #15 (comment) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "approach"
Remove the .html files from the pr. These files are automatically generated by doxygen. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Removed the .html files from the pull request and signed the CLA. |
@abhvious — I signed the CLA with my primary google account address, but that address is not what I primarily use for GitHub contributions. Google claims my primary address as used here is associated with another Google Account, but I have no way to learn what account that is, nor dissociate it (if that association is incorrect), etc. I'm stonewalled. Which means that my tiny, human language contributions, block @sukrucildirr's larger contribution. Sad. |
Thank you for your kind words. Maybe you can find it in the settings. |
@google-admin @abhvious — Both of my relevant email addresses ( |
No problem, sir. Let’s wait for the final check from @abhvious . |
Fixed typos across codebase.