Skip to content

chore: fix typos across codebase #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sukrucildirr
Copy link

Fixed typos across codebase.

Copy link

google-cla bot commented Jul 21, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes incorrect fix (twice) for typo

@sukrucildirr
Copy link
Author

fixes incorrect fix (twice) for typo

Thanks, sir.

@abhvious
Copy link
Collaborator

Thank you for these fixes. Embarrassing that we didn't run a spellcheck.

Can both of you please sign the CLA in comment #15 (comment) ?

Copy link
Collaborator

@abhvious abhvious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "approach"

@abhvious
Copy link
Collaborator

Remove the .html files from the pr. These files are automatically generated by doxygen.

@sukrucildirr
Copy link
Author

Remove the .html files from the pr. These files are automatically generated by doxygen.

Removed the .html files from the pull request and signed the CLA.

@TallTed
Copy link
Collaborator

TallTed commented Jul 22, 2025

@abhvious — I signed the CLA with my primary google account address, but that address is not what I primarily use for GitHub contributions. Google claims my primary address as used here is associated with another Google Account, but I have no way to learn what account that is, nor dissociate it (if that association is incorrect), etc. I'm stonewalled. Which means that my tiny, human language contributions, block @sukrucildirr's larger contribution. Sad.

@sukrucildirr
Copy link
Author

@abhvious — I signed the CLA with my primary google account address, but that address is not what I primarily use for GitHub contributions. Google claims my primary address as used here is associated with another Google Account, but I have no way to learn what account that is, nor dissociate it (if that association is incorrect), etc. I'm stonewalled. Which means that my tiny, human language contributions, block @sukrucildirr's larger contribution. Sad.

Thank you for your kind words. Maybe you can find it in the settings.

@TallTed
Copy link
Collaborator

TallTed commented Jul 23, 2025

@google-admin @abhvious — Both of my relevant email addresses ([email protected] and [email protected]) are associated with my GitHub ID (@TallTed). I apparently cannot associate the second email address with my primary GoogleID (the first email address) because it is already associated with another GoogleID (which I am not offered any way to know). This, combined with there being no way to remove myself from this PR, makes it impossible for my (tiny!) contribution here to be auto-approved by @google-cla; hence, this blocks @sukrucildirr's (larger) contribution. It might be time to rethink some aspects of how Google manages FOSS contributions!

@sukrucildirr
Copy link
Author

@google-admin @abhvious — Both of my relevant email addresses ([email protected] and [email protected]) are associated with my GitHub ID (@TallTed). I apparently cannot associate the second email address with my primary GoogleID (the first email address) because it is already associated with another GoogleID (which I am not offered any way to know). This, combined with there being no way to remove myself from this PR, makes it impossible for my (tiny!) contribution here to be auto-approved by @google-cla; hence, this blocks @sukrucildirr's (larger) contribution. It might be time to rethink some aspects of how Google manages FOSS contributions!

No problem, sir. Let’s wait for the final check from @abhvious .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants