Retrieve Mozc's installation directory from registry #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation to switch Mozc's installation directory from %ProgramFiles(x86)%\Mozc into %ProgramFiles%\Mozc without user observable downtime (google#1086). Currently the directory %ProgramFiles(x86)%\Mozc is effectively hard coded in 'mozc_tip{32,64}.dll'. This means if older versions of 'mozc_tip{32,64}.dll' continue assuming the previous installation directory until it is unloaded or the process is restarted. To avoid such mismatch, with this commit SystemUtil::GetServerDirectory() starts dynamically retrieving Mozc's installation directory from registry by checking COM entries of 'mozc_tip64.dll'. If it fails, we fall back to the previous behavior. Note that this is the first step of the migration and we cannot go to the next step until 'mozc_tip{32,64}.dll' with this commit is deployed to users.
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the directory
%ProgramFiles(x86)%\Mozcis effectively hard coded inmozc_tip{32,64}.dll. This is a big challenge when we want to switch Mozc's installation directory from%ProgramFiles(x86)%\Mozcto%ProgramFiles%\Mozc.So as not to bother users during the migration, with this commit
SystemUtil::GetServerDirectory()first attempts to retrieve Mozc's installation directory from registry by checking the COM entry formozc_tip64.dll.The next step is to deploy
mozc_tip{32,64}.dllusers with this commit.Issue IDs
%ProgramFiles%\Mozcrather than%ProgramFiles(x86)%\Mozc#1086