Update Android NDK patch so that Android NDK can be handled gracefully #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukawa
force-pushed
the
upadte_rules_android_ndk_patch
branch
from
7f4cf94 to
4957ca0
Compare
This is a preparation before removing the dependency on Docker from our Android build instructions (google#1181). Suppose we want to specify 'path' attribute to 'android_ndk_repository_extension' so that we can specify the actual path to the Android NDK in our MODULE.bazel. android_ndk_repository_extension = use_extension( "@rules_android_ndk//:extension.bzl", "android_ndk_repository_extension", ) android_ndk_repository_extension.configure( path = "$WORKSPACE_ROOT/third_party/ndk/android-ndk-r28", ) use_repo(android_ndk_repository_extension, "androidndk") The problem is that there is currently no way to conditionally the the above path attribute depending on the host platform and/or the target platform. As a result, the above configuration takes effect not only on Linux but also on Windows environment, where we do not plan to support building libmozc.so right now. To gracefully handle the above scenario, this commit updates our patch to 'rules_android_ndk' to generate an empty BUILD.bazel file when an Android NDK does not exist at the location specified by ANDROID_NDK_HOME or the path attribute. Basically this is a superset of the behavior of the current patch, where an empty BUILD.bazel file is generated unless ANDROID_NDK_HOME is explicitly specified or the path attribute is set. In general there should be no observable behavior change as long as the build is currently passing.
yukawa
force-pushed
the
upadte_rules_android_ndk_patch
branch
from
4957ca0 to
33410cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation before removing the dependency on Docker from our Android build instructions (#1181).
Suppose we want to set 'path' attribute to
android_ndk_repository_extensionso that we can specify the actual path to the Android NDK in ourMODULE.bazel.The problem is that there is currently no way to conditionally the the above path attribute depending on the host platform and/or the target platform. As a result, the above configuration takes effect not only on Linux but also on Windows environment, where we do not plan to support building libmozc.so right now.
To gracefully handle the above scenario, this commit updates our patch to
rules_android_ndkto generate an emptyBUILD.bazelfile when an Android NDK does not exist at the location specified byANDROID_NDK_HOMEor the path attribute. Basically this is a superset of the behavior of the current patch, where an emptyBUILD.bazelfile is generated unlessANDROID_NDK_HOMEis explicitly specified or the path attribute is set.In general there should be no observable behavior change as long as the build is currently passing.
Issue IDs
Steps to test new behaviors (if any)