Also download Android NDK in update_deps.py
#1183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation before removing the dependency on Docker from our Android build instructions (google#1181). With this commit running the 'update_deps.py' also downloads Android NDK for macOS and Linux then extract it under third_party/ndk/. This would enable us to fully control which version of Android NDK should be used to build Android Library ('libmozc.so') in a subsequent commit. At this moment only the observable difference is that the Android NDK will be extracted under third_party/ndk/. There must be no difference in the final artifact yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation before removing the dependency on Docker from our Android build instructions (#1181).
With this commit running the
update_deps.pyalso downloads Android NDK for macOS and Linux then extract it underthird_party/ndk/.This would enable us to fully control which version of Android NDK should be used to build Android Library (
libmozc.so) in a subsequent commit.At this moment only the observable difference is that the Android NDK will be extracted under
third_party/ndk/. There must be no difference in the final artifact yet.Issue IDs
Steps to test new behaviors (if any)