Support building a universal installer for Windows#1434
Open
yukawa wants to merge 1 commit intogoogle:masterfrom
Open
Support building a universal installer for Windows#1434yukawa wants to merge 1 commit intogoogle:masterfrom
yukawa wants to merge 1 commit intogoogle:masterfrom
Conversation
yukawa
force-pushed
the
issue_1430
branch
2 times, most recently
from
46d0a83 to
0128500
Compare
As a short-term solution for ARM64 support on Windows, this commit adds a new option to build a special variant of the existing x64 installer, which can be installed on both x64 and ARM64 Windows systems. Basically the idea is to rely on x64 emulation on ARM64 Windows whenever possible, while deploying "mozc_tip64x.dll" and "mozc_tip64arm.dll" as the minimum set of ARM64-native binaries. When installed on x64 Windows, we can register "mozc_tip64.dll" as the COM TIP module as usual. As for ARM64 Windows, on the other hand, we register "mozc_tip64x.dll" as the COM TIP module as we do so for ARM64 native installer. Other executables such as "mozc_server.exe" and "mozc_renderer.exe" can run in both x64 and ARM64 Windows as well as they are built as x64 binaries. Of course, maintaining two separate installers (x64 and ARM64) is supposed to be the ideal solution in the long run, but this universal installer would help us deploy ARM64 support on Windows in a timely manner. Note that ARM64 toolchains are not required unless you explicitly specify "--config win_universal_installer" build option. Closes google#1430
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a short-term solution for ARM64 support on Windows, this commit adds a new option to build a special variant of the existing x64 installer, which can be installed on both x64 and ARM64 Windows systems.
Basically the idea is to rely on x64 emulation on ARM64 Windows whenever possible, while deploying
mozc_tip64x.dllandmozc_tip64arm.dllas the minimum set of ARM64-native binaries. When installed on x64 Windows, we can registermozc_tip64.dllas the COM TIP module as usual. As for ARM64 Windows, on the other hand, we registermozc_tip64x.dllas the COM TIP module as we do so for ARM64 native installer. Other executables such asmozc_server.exeandmozc_renderer.execan run in both x64 and ARM64 Windows as well as they are built as x64 binaries.Of course, maintaining two separate installers (x64 and ARM64) is supposed to be the ideal solution in the long run, but this universal installer would help us deploy ARM64 support on Windows in a timely manner.
Note that ARM64 toolchains are not required unless you explicitly specify
--config win_universal_installerbuild option.Closes #1430
Issue IDs
Steps to test new behaviors (if any)
Mozc64.msiMozc64.msican be installed into both x64 and ARM64 Windows machines.