Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transfer-function): show data CDF in transfer function #607

Merged
merged 10 commits into from
Jul 24, 2024

Conversation

seankmartin
Copy link
Contributor

@seankmartin seankmartin commented Jul 1, 2024

Updates the transfer function to use the existing histogram information computed for invlerps, and displays the same kind of CDF.

image

@seankmartin seankmartin marked this pull request as ready for review July 8, 2024 10:54
@seankmartin seankmartin changed the title Feature - show data CDF in transfer function feat(transfer-function): show data CDF in transfer function Jul 18, 2024
@jbms jbms merged commit aa9efda into google:master Jul 24, 2024
7 of 19 checks passed
aaronkanzer pushed a commit to lincbrain/neuroglancer that referenced this pull request Jan 24, 2025
* feat: mark transfer function as needing histogram

* feat: mark bounds for transfer function histogram

* refactor: pull histogram calculation into function

* feat: link up a transfer function CDF line shader

* fix: linting

* fix(log): correect console.log of histogram from VR

* fix: correct histogram index when invlerp and tfs are mixed

* feat: change transfer function line colours

* refactor: define CDF shader as a function
@seankmartin seankmartin deleted the feature/transfer-function-cdf branch January 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants