fix(layer): ensure layer references are unset when the associated layer is deleted#669
Merged
jbms merged 1 commit intogoogle:masterfrom Nov 20, 2024
Merged
Conversation
…er is deleted removed disposed method on SharedDisjointUint64Sets to prevent potential "cannot read properties of undefined" errors as garbage collection benefit is likely insignificant
Collaborator
|
Thanks! |
aaronkanzer
pushed a commit
to lincbrain/neuroglancer
that referenced
this pull request
Jan 24, 2025
…er is deleted (google#669) removed disposed method on SharedDisjointUint64Sets to prevent potential "cannot read properties of undefined" errors as garbage collection benefit is likely insignificant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also removed disposed method on SharedDisjointUint64Sets to prevent potential "cannot read properties of undefined" errors as garbage collection benefit is likely insignificant
replaces #664