Update Nomulus deployment script #2677
Merged
+43
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianglai
commented
Feb 14, 2025
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jianglai)
ptkach
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status:
ptkach
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Reviewed 1 of 2 files at r2.
Reviewable status:
We only deploy to the us-central1 cluster in order to minimize database locality issue.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only deploy to the us-central1 cluster in order to minimize database
locality issue.
This change is