Skip to content

[surrealdb] Install Rust 1.84 to fix build with Option::is_none_or #13292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

emmanuel-keller
Copy link

@emmanuel-keller emmanuel-keller commented May 8, 2025

SurrealDB and its dependency tree require stable Rust ≥ 1.84 (Option::is_none_or was stabilised in 1.84).

Builds on the current base-builder image fails with:

error[E0658]: use of unstable library feature 'is_none_or'

This change installs the 1.84.0 toolchain (minimal profile + rust-src) and sets it as the default.

https://issues.oss-fuzz.com/issues/398679984

Copy link

google-cla bot commented May 8, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented May 8, 2025

emmanuel-keller is either the primary contact or is in the CCs list of projects/surrealdb.
emmanuel-keller is a new contributor to projects/surrealdb. The PR must be approved by known contributors before it can be merged. The past contributors are: rowan-baker, gguillemas, catenacyber, nathaniel-brough

@emmanuel-keller emmanuel-keller marked this pull request as ready for review May 8, 2025 10:00
@emmanuel-keller emmanuel-keller changed the title [surrealdb] Install Rust 1.82 to fix build with Option::is_none_or [surrealdb] Install Rust 1.84 to fix build with Option::is_none_or May 8, 2025
@rowan-baker
Copy link
Contributor

rowan-baker commented Jun 5, 2025

I'd approve this PR, yet I do not have write access cc @catenacyber @nathaniel-brough @jonathanmetzman

@nathaniel-brough
Copy link
Contributor

Looks good to me. I don't have write access either unfortunately.

@jonathanmetzman
Copy link
Contributor

Sorry can you ping me again if CI passes.

@jonathanmetzman jonathanmetzman enabled auto-merge (squash) June 6, 2025 22:04
@jonathanmetzman
Copy link
Contributor

Nevermind, it will be automatically merged if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants