-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[surrealdb] Install Rust 1.84 to fix build with Option::is_none_or #13292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[surrealdb] Install Rust 1.84 to fix build with Option::is_none_or #13292
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
emmanuel-keller is either the primary contact or is in the CCs list of projects/surrealdb. |
I'd approve this PR, yet I do not have write access cc @catenacyber @nathaniel-brough @jonathanmetzman |
Looks good to me. I don't have write access either unfortunately. |
Sorry can you ping me again if CI passes. |
Nevermind, it will be automatically merged if it passes. |
SurrealDB and its dependency tree require stable Rust ≥ 1.84 (
Option::is_none_or
was stabilised in 1.84).Builds on the current base-builder image fails with:
This change installs the 1.84.0 toolchain (minimal profile + rust-src) and sets it as the default.
https://issues.oss-fuzz.com/issues/398679984