base-builder: introspector: disable dead code optimizations #13315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite -O0 these optimizations still happen. This is particularly important for OFG runs where we run on new projects as they will be based on an empty fuzzing harness, meaning a lot of the code is potentially affected. Less so on existing projects where the optimizations are less impactful.
Collaborator
Author
|
/gcbrun trial_build.py all --sanitizer introspector --fuzzing-engine libfuzzer |
oliverchang
approved these changes
May 15, 2025
| ENV SANITIZER_FLAGS_thread "-fsanitize=thread" | ||
|
|
||
| ENV SANITIZER_FLAGS_introspector "-O0 -flto -fno-inline-functions -fuse-ld=gold -Wno-unused-command-line-argument" | ||
| ENV SANITIZER_FLAGS_introspector "-O0 -flto -fno-inline-functions -fuse-ld=gold -Wno-unused-command-line-argument -Wl,--mllvm,-compute-dead=false -disable-globaldce" |
Collaborator
There was a problem hiding this comment.
are there any implications on speed or resulting database size?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite -O0 these optimizations still happen. This is particularly important for OFG runs where we run on new projects as they will be based on an empty fuzzing harness, meaning a lot of the code is potentially affected. Less so on existing projects where the optimizations are less impactful.