[goipp] Initial integration #13391
[goipp] Initial integration #13391
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
mdimado is integrating a new project: |
| @@ -0,0 +1,23 @@ | |||
| # Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
Do we need to keep these copyright lines in place? I think they are useful when the file is similar enough to the template ones, but here not much of the original content is being kept.
There was a problem hiding this comment.
AFAIK, these files need to have the copyright header (every other project that I have seen has the copyright header in the Dockerfile and the build.sh). There's also a License Header Lint GCF / header-check that passed in this PR
| @@ -0,0 +1,19 @@ | |||
| #!/bin/bash -eu | |||
There was a problem hiding this comment.
Same observation about the copyright ✌️
| - "[email protected]" | ||
| language: go | ||
| fuzzing_engines: | ||
| - libfuzzer |
There was a problem hiding this comment.
These are the values embedded in the documentation. Did we somehow verify if they are the best for our use case?
There was a problem hiding this comment.
In the documentation, it says, The only supported fuzzing engine and sanitizer are libfuzzer and address, respectively.
| homepage: "https://github.com/OpenPrinting/goipp" | ||
| main_repo: "https://github.com/OpenPrinting/goipp" | ||
| primary_contact: "[email protected]" | ||
| auto_ccs: |
There was a problem hiding this comment.
Perhaps you can check with Alexander to see if he would like to be included in the CC list for potential bug reports?
This PR adds initial integration for the goipp project - a Go implementation of the Internet Printing Protocol (IPP) core.
All fuzz harnesses are maintained externally in the OpenPrinting/fuzzing repository.
CC: @tillkamppeter @iosifache @fish98