Conversation
|
FranzBusch is a new contributor to projects/swift-nio. The PR must be approved by known contributors before it can be merged. The past contributors are: catenacyber, asraa |
There was a problem hiding this comment.
This overall looks good. There's a current issue which caused the ubuntu* base images not to be pushed to the registry #14338 which has just been fixed #14340 Will wait for the base images to be propagated to test this (in 24h or so) and then merge this PR.
Edit: can see they've already been pushed actually.
|
IIUC, the |
dd6f08a to
4f968e1
Compare
|
@kleisauke Sorry it took me a bit to get back to this. I updated the |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
@DavidKorczynski thanks for kicking the build. It looks like the Swift deps weren't correct and I just updated that. Can you kick the build again? |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
The plan now is to land #14486 and then follow the steps Thomas mentions here #14486 (comment) "land this and then stack #14342 on top, and thus move both of your base images forward, just to different Swift versions.". Thomas has a point on making sure 20.04 follows |
I may go back on this and simply go through with this PR. We have so few swift projects and think we can look beyond 20.04. For that reason if we can get the CI working here then we should just land this. |
|
/gcbrun trial_build.py swift-nio swift-protobuf grpc-swift --force-build |
|
Thanks for pushing on this @DavidKorczynski. It is not entirely clear to me why the trial build failed. |
|
This looks to be failing: |
|
Hm weird since I added |
|
@DavidKorczynski I am confused why this not picking up my changes in |
hmm, let me run this locally and see if I run into the same issue |
|
Did this succeed for you locally @FranzBusch ? When I try to build it I get the error: You can try to build the images by using the below changes in |
|
I will try to reproduce this locally more. In the mean time can we land #14486 @DavidKorczynski? That PR seems to pass and gets us to 6.1.3 already. I can rebase this PR to get us to 6.2.3 afterwards. |
|
@FranzBusch #14486 got merged. Note: I had to do some file renames to pass checks in other places, so merging this up might be a little more work because of that. |
00a0176 to
1e370ff
Compare
Updates the Swift version to the latest released Swift version. This ensures that the projects are fuzzed against the latest compiler and runtime versions. Additionally, some projects don't support 5.10 anymore so bumping to 6.2 should give us the latest versions of those projects. Update projects/swift-nio/Dockerfile Co-authored-by: Kleis Auke Wolthuizen <[email protected]> Update base os version Update swift deps
1e370ff to
ee5b536
Compare
|
@DavidKorczynski @thomasvl I rebased this PR on the latest |
kicked off the CI |
|
Are those errors flake? They don't seem like they would be related to changing the swift version. |
Updates the Swift version to the latest released Swift version. This ensures that the projects are fuzzed against the latest compiler and runtime versions. Additionally, some projects don't support 5.10 anymore so bumping to 6.2 should give us the latest versions of those projects.