Open
Conversation
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
|
arthurscchan has previously contributed to projects/exprtk. The previous PR was #14581 |
DavidKorczynski
requested changes
Jan 2, 2026
Contributor
|
@DavidKorczynski / @arthurscchan this looks good to me. 👍 |
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
ArashPartow
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt to add run_tests.sh to the exprtk project, following suggestions in #14581 and #14613.
@ArashPartow, apologies for rushing my previous PR and for not considering the impact on build size and build time. I have changed the script so that only the exprtk_test unit tests are built, to minimise the impact on build size and build time.
run_tests.sh is used as part of Chronos with cached builds:
https://github.com/google/oss-fuzz/tree/master/infra/chronos#chronos-feature--running-tests-of-a-project