Skip to content

Conversation

@ADITYATIWARI342005
Copy link

Installs poppler-data package and copies encoding files to $OUT/poppler-data for runtime access.

Why: Poppler's GlobalParams requires CMap and encoding data for CJK text and character mapping operations. Currently unavailable in OSS-Fuzz environment.

Changes:

  • Dockerfile: Install poppler-data package
  • build.sh: Copy /usr/share/poppler to $OUT/poppler-data

Coordination:

cc: @tsdgeos

…ng directory scanning in fuzzer environment

Signed-off-by: ADITYA TIWARI <[email protected]>
@google-cla
Copy link

google-cla bot commented Jan 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

ADITYATIWARI342005 is a new contributor to projects/poppler. The PR must be approved by known contributors before it can be merged. The past contributors are: tsdgeos, maflcko, vanhauser-thc

@tsdgeos
Copy link
Contributor

tsdgeos commented Jan 5, 2026

Please use make install as described by poppler data readme

@ADITYATIWARI342005
Copy link
Author

Hi @tsdgeos
I have made the changes as per your instructions, please review it.

Remove poppler-data installation step from build script
@ADITYATIWARI342005
Copy link
Author

Hi @tsdgeos
Ready for review.

please do not add useless comments. we do not need a comment saying that make install does install.

Removed. the file had similar comments, so I mentioned it to follow the practice.

Copy link
Contributor

@tsdgeos tsdgeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidKorczynski please merge :)

@ADITYATIWARI342005
Copy link
Author

Hi @tsdgeos
I was testing its integration with the poppler MR, and I encountered that the Makefile's install target attempted to install poppler-data.pc to $(datadir)/pkgconfig (defaults to /usr/local/share/pkgconfig), which failed with permission denied in the OSS-Fuzz build environment, causing make to exit before installing the cMap directory.

so I changed it to make install pkgdatadir=$OUT/poppler-data datadir=$OUT/tmp-datadir, & I have verified the build and integration to be functional on this new configuration.

@tsdgeos
Copy link
Contributor

tsdgeos commented Jan 8, 2026

Looks good.

@DavidKorczynski please merge

@ADITYATIWARI342005 there's no need to keep merging master to this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants