-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[poppler] : Add poppler-data support for Poppler fuzzers #14752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[poppler] : Add poppler-data support for Poppler fuzzers #14752
Conversation
…ng directory scanning in fuzzer environment Signed-off-by: ADITYA TIWARI <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
ADITYATIWARI342005 is a new contributor to projects/poppler. The PR must be approved by known contributors before it can be merged. The past contributors are: tsdgeos, maflcko, vanhauser-thc |
|
Please use make install as described by poppler data readme |
Updated installation method for poppler-data to use 'make install'.
|
Hi @tsdgeos |
Remove poppler-data installation step from build script
|
Hi @tsdgeos
Removed. the file had similar comments, so I mentioned it to follow the practice. |
tsdgeos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidKorczynski please merge :)
Added 'datadir' option to make install command.
|
Hi @tsdgeos so I changed it to |
|
Looks good. @DavidKorczynski please merge @ADITYATIWARI342005 there's no need to keep merging master to this branch |
Installs poppler-data package and copies encoding files to
$OUT/poppler-datafor runtime access.Why: Poppler's GlobalParams requires CMap and encoding data for CJK text and character mapping operations. Currently unavailable in OSS-Fuzz environment.
Changes:
/usr/share/popplerto$OUT/poppler-dataCoordination:
cc: @tsdgeos