Add CachedAssetStore #636
Open
Add CachedAssetStore #636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers to specialize what storage the Butler is using when fetching assets.
When provided, the FilesystemAssetStore can insert the RunID as part of the asset path, which matches the layout of the GCS asset store. stacked-commit: true
stacked-commit: true
stacked-commit: true
wbxyz
force-pushed
the
push-rppmsprxussy
branch
2 times, most recently
from
22d0f63 to
ceb7293
Compare
stacked-commit: true
msuozzo
approved these changes
Jul 17, 2025
| @@ -251,3 +251,93 @@ func NewFilesystemAssetStoreWithRunID(fs billy.Filesystem, runID string) *Filesy | |||
| func NewFilesystemAssetStore(fs billy.Filesystem) *FilesystemAssetStore { | |||
| return NewFilesystemAssetStoreWithRunID(fs, "") | |||
| } | |||
|
|
|||
| type CachedAssetStore struct { | |||
There was a problem hiding this comment.
can we add some docs here specifying the caching behavior?
| } | ||
|
|
||
| func (cr *cachedReader) Close() error { | ||
| _, flushErr := io.ReadAll(cr.tee) |
There was a problem hiding this comment.
nit: maybe a quick comment about why a flush is necessary here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.