test: introduce a special "cherry-picking" mock server for providing local databases #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…double slash ("//")
…ps in table output
G-Rath
commented
Feb 11, 2025
| @@ -18,6 +20,210 @@ func TestMain(m *testing.M) { | |||
| if err != nil { | |||
| panic(err) | |||
| } | |||
|
|
|||
| // localmatcher.ZippedDBRemoteHost = testdb.NewZipDBCacheServer().URL | |||
| localmatcher.ZippedDBRemoteHost = testdb.NewZipDBCherryPickServer(map[string][]string{ | |||
There was a problem hiding this comment.
for now I just copied all the OSVs that were present in the snapshots for each database
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return | ||
| } | ||
|
|
||
| b, err := os.ReadFile(db.StoredAt) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CLI tests for the local databases are the slowest as they involve downloading zip files multiple times and the databases in particular include ones like
DebianandOSS-Fuzzwhich are the largest of the lot - with theTestRun_LocalDatabasescases included, the suite takes about 90 seconds to run, whereas without it it takes less than 30 seconds.This attempts to improve the performance of our test suite by introducing a mocking server that acts like the GCP storage bucket which serves in-memory zip files containing specific OSVs for each ecosystem that have been "cherry-picked", which brings us back to around the 30 second mark.
Aside from the downside of this being a fake GCP storage bucket (which is technically a downside, but I doubt the behaviour of GCP storage is going to change significantly enough to make this an actual risk), this does mean we miss out on testing both the zip-based databases and the specific OSVs they contain.
On the other hand, this does mean we shouldn't have to update snapshots as often since we control exactly what OSVs are included in the checks.
Resolves #1567