Skip to content

feat: deprecate --experimental- flags in favor of shorter --x- versions#2589

Draft
G-Rath wants to merge 2 commits intogoogle:mainfrom
ackama:feat/rename-exp-flags
Draft

feat: deprecate --experimental- flags in favor of shorter --x- versions#2589
G-Rath wants to merge 2 commits intogoogle:mainfrom
ackama:feat/rename-exp-flags

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 4, 2026

"experimental" is a tedious word to type, so this switches to the much shorter "x" similar to the convention used by the Go stdlib

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.00%. Comparing base (ed297e0) to head (400a3f6).

Files with missing lines Patch % Lines
cmd/osv-scanner/scan/source/command.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
- Coverage   68.01%   68.00%   -0.01%     
==========================================
  Files         173      173              
  Lines       13389    13420      +31     
==========================================
+ Hits         9106     9126      +20     
- Misses       3575     3586      +11     
  Partials      708      708              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 5, 2026

ugh the "flags action" order thing is an issue here too 🤦

@G-Rath G-Rath force-pushed the feat/rename-exp-flags branch from 28eced9 to 54920ab Compare March 5, 2026 00:39
@G-Rath G-Rath force-pushed the feat/rename-exp-flags branch 3 times, most recently from 9e8356f to d5d8643 Compare March 6, 2026 20:54
@G-Rath G-Rath force-pushed the feat/rename-exp-flags branch from d5d8643 to 400a3f6 Compare March 10, 2026 00:19
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

},
&cli.BoolFlag{
Name: "x-no-default-plugins",
Usage: "disable default plugins, instead using only those enabled by --experimental-plugins",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should mention --x-plugins right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants