Fix/trace process shell/erorr on firefox #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsavitski
requested review from
primiano
and removed request for
rsavitski and
stevegolton
LalitMaganti
previously requested changes
Apr 22, 2025
primiano
reviewed
Apr 23, 2025
Member
primiano
left a comment
primiano
left a comment
There was a problem hiding this comment.
Thanks a lot for spotting the issue and sending a patch to this.
Few comments but overall looks sensible
Member
|
(See comments still open) |
Contributor
Author
I add some comments in the review, maybe we can have a discuss on it. |
Member
Sorry but most of our comments do not seem to have been addressed. Please don't mark the comments as resolved unless you have actually resolved them. |
primiano
approved these changes
Apr 25, 2025
stevegolton
reviewed
Apr 26, 2025
primiano
reviewed
Apr 28, 2025
primiano
approved these changes
Apr 30, 2025
Member
primiano
left a comment
primiano
left a comment
There was a problem hiding this comment.
Thanks a lot for finding an fixing this
stevegolton
approved these changes
Apr 30, 2025
stevegolton
dismissed
LalitMaganti’s stale review
Looks like Lalit's requested changes have been addressed
primiano
approved these changes
Apr 30, 2025
zezeozue
pushed a commit
that referenced
this pull request
May 8, 2025
fix firefox with trace_process_shell issue: #1301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix firefox with trace_process_shell
issue: #1301