Limited the existence of a TID to one at a time #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessTracker permitted the creation of multiple threads with same TID but different UTIDs, mainly to address data loss scenarios. Refactored the code to have better semantics to address these cases. The ClearThread method removes all preexisting UTIDs from the active thread map, acting as a barrier point from which a new thread can be created for a preexisting TID. Also, updated the API so that GetOrCreateThread becomes the primary thread creation method, forcing a single TID and thread association at any point in time. Bug: 425694654
LalitMaganti
approved these changes
Jul 2, 2025
| @@ -146,7 +146,8 @@ std::optional<UniqueTid> GenericKernelParser::GetUtidForState(int64_t ts, | |||
| stats::generic_task_state_invalid_order); | |||
| return std::nullopt; | |||
| } | |||
| UniqueTid utid = context_->process_tracker->StartNewThread(ts, tid); | |||
| UniqueTid utid = context_->process_tracker->GetOrCreateThread(tid); | |||
There was a problem hiding this comment.
Shouldn't you ClearThread here?
There was a problem hiding this comment.
@LalitMaganti Not really because we are already explicitly checking above that the thread doesn't exist (line 144).
There was a problem hiding this comment.
Can you add a comment then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcessTracker permitted the creation of multiple threads with same TID but different UTIDs, mainly to address data loss scenarios. Refactored the code to have better semantics to address these cases. The ClearThread method removes all preexisting UTIDs from the active thread map, acting as a barrier point from which a new thread can be created for a preexisting TID.
Also, updated the API so that GetOrCreateThread becomes the primary thread creation method, forcing a single TID and thread association at any point in time.
Bug: 425694654