ui: group kthread process tracks in addition to thread tracks #3256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up for traces containing perf samples + procfs trees, but no sched_switch to supply thread names. The result is that the grouped kernel thread tracks end up mostly anonymous (since the procfs scraping is only supplying the process names). Additionally, a subset of those threads does end up with a name due to the trace including "task_rename" ftrace events. On modern traces, we actually know if the "cmdline" field in the trace was set from /proc/pid/comm, so we can use that information to name the main thread as well.
rsavitski
force-pushed
the
dev/rsavitski/perf-process-group
branch
from
28ead99 to
b5dd331
Compare
rsavitski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently moving all thread-scoped tracks into the "Kernel
threads" group, but are abandoning the process-scoped tracks. This patch
addresses that by adjusting ProcessThreadGroups.
While there, simplify the kthread query since there's a
vizanalog,and remove the always-empty summary track (which makes the group track
thin, but I think that's fine).