Skip to content

ui: delineate last counter sample in the trace #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ui: delineate last counter sample in the trace #3367

wants to merge 3 commits into from

Conversation

@LalitMaganti
Copy link
Member

@LalitMaganti LalitMaganti commented Oct 22, 2025 •
edited
Loading

  1. we now have a gradient from the last sample to the right edge of the screen
  2. we use a "dashed" line rather than a solid line from the last sample to the right edge of the screen
  3. in the details panel, we mark it as -1 duration i.e. "did not complete" instead of zero duration
  4. when you hover on the sample, we preserve the dashed line instead of the solid line

Fixes: #3341

@LalitMaganti
ui: delineat last counter sample in the trace
a1c86ec 
Use a gradiient + dashed line to indicate the last sample. This allows making clear that
the last sample didn't have any further data and *not* that we know the sample had this value
until the end of the trace
@LalitMaganti LalitMaganti changed the title ui: delineat last counter sample in the trace ui: delineate last counter sample in the trace Oct 22, 2025
@LalitMaganti LalitMaganti mentioned this pull request Oct 22, 2025
Open
stevegolton
stevegolton approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@stevegolton stevegolton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me % one comment

@LalitMaganti LalitMaganti marked this pull request as ready for review October 22, 2025 11:30
@LalitMaganti LalitMaganti requested a review from a team as a code owner October 22, 2025 11:30
@LalitMaganti LalitMaganti force-pushed the dev/lalitm/counter-test branch from 7771d04 to d1e70e7 Compare October 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevegolton stevegolton stevegolton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Counter samples continue until the end of track

3 participants

@LalitMaganti @stevegolton