perfetto sdk: Add ID and Parent UUID checks for NamedTrack reuse #3516
+73
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the condition in `usingNamedTrack`(from `PerfettoTrackEventBuilder.java`) to also check `id` and `parentUuid` before reusing a cached `NamedTrack` instance. This ensures tracks with the same name but different IDs or parent UUIDs are treated as distinct. Added new test cases in `PerfettoTraceTest.java` (`testTwoNamedTrackWithDifferentIds`, `testTwoNamedTrackWithDifferentParentUuids`) to validate that distinct tracks are created when IDs or parent UUIDs differ for the same name. Test: bazelisk test //:src_android_sdk_java_test_perfetto_trace_instrumentation_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the condition in
usingNamedTrack(fromPerfettoTrackEventBuilder.java) to also checkidandparentUuidbefore reusing a cachedNamedTrackinstance. This ensures tracks with the same name but different IDs or parent UUIDs are treated as distinct.Added new test cases in
PerfettoTraceTest.java(testTwoNamedTrackWithDifferentIds,testTwoNamedTrackWithDifferentParentUuids) to validate that distinct tracks are created when IDs or parent UUIDs differ for the same name.Test: bazelisk test //:src_android_sdk_java_test_perfetto_trace_instrumentation_test