Dev/chengxli/cpu uptime calculator #3528
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method to calculate the CPU uptime based on the expected cost to enter into respective C-states
LalitMaganti
reviewed
Nov 4, 2025
| -- Table which groups scheduling information along with the CPU idle state | ||
| -- information. This is meant to be used in conjunciton with the android_cpu_uptime_cost | ||
| -- calculation macro. | ||
| CREATE PERFETTO TABLE android_active_sched_joined ( |
Member
There was a problem hiding this comment.
Really don't like this table name. Please be more descriptive and consistent with the style of the stdlib instead of just calling it "joined"
LalitMaganti
reviewed
Nov 4, 2025
| -- Calculation: | ||
| -- * Uptime1 (First Process): Sched1_dur + C2_cost + C3_cost | ||
| -- * UptimeN (Subsequent Processes, N > 1): SchedN_dur | ||
| CREATE PERFETTO MACRO android_cpu_uptime_cost( |
Member
There was a problem hiding this comment.
Both uptime and cost are a bit vague here. Uptime means to me device uptime (i.e. time since boot). Now usually I think that word also includes time in suspend (tho I'm not 100% on that).
Can we use better words?
LalitMaganti
requested changes
Nov 4, 2025
| @@ -0,0 +1,195 @@ | |||
| -- | |||
Member
There was a problem hiding this comment.
All of this code needs tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CPU uptime calculation to the stdlib.
Adding a table and macro which calculates the theoretical CPU uptime cost attributed to each thread/process.
It works by assigning the "cost" (idle duration required) to enter deeper C-states (C2, C3, etc.) to the thread that kept the CPU active during that time, preventing the C-state entry.