Skip to content

Conversation

@dreveman
Copy link
Collaborator

@dreveman dreveman commented Nov 5, 2025

Matches the PerfettoProducerBackendInitArgsSetShmemSizeHintKb documentation where callers are told to that a multiple of 4KB must be used.

No actual change in behavior with a release build of the tracing service as a 0 value will be adjusted to become 4KB but it removes an "Invalid configured SMB sizes" message when using a debug build of the tracing service.

Matches the PerfettoProducerBackendInitArgsSetShmemSizeHintKb
documentation where callers are told to that a multiple of 4KB
must be used.

No actual change in behavior with a release build of the tracing
service as a 0 value will be adjusted to become 4KB but it removes
an "Invalid configured SMB sizes" message when using a debug build
of the tracing service.
@dreveman dreveman requested a review from a team as a code owner November 5, 2025 16:44
@dreveman dreveman requested a review from LalitMaganti November 5, 2025 16:46
@LalitMaganti LalitMaganti requested a review from primiano November 5, 2025 16:48
@dreveman
Copy link
Collaborator Author

dreveman commented Nov 5, 2025

@ddiproietto Far from critical but the debug logs from the service were confusing to me and had me think that the shmem_size_hint_kb API wasn't working at first glance. It works fine without this. Just always producing a warning message.

@primiano
Copy link
Member

primiano commented Nov 5, 2025

@ddiproietto left the team last week, I'm happy to look at these changes for the time being.

Yes that log message is annoying.
My theory is that rather than doing it in here , we should do somewhere inside in the impl (still on the SDK side), maybe TracingMuxerImpl::InitializeInstance or something inner (on the run now, but can look more later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants