Skip to content

Conversation

@stevegolton
Copy link
Member

@stevegolton stevegolton commented Nov 12, 2025

Currently a lot of the omnibox business logic is contained in the UIMain component. The Omnibox component in omnibox.ts is a purely a presentational widget.

The issue is that omnibox.ts is where one would expect to find all the omnibox logic, both business and presentational.

This patch moves all the business logic into a new component called Omnibox, and the original Omnibox presenational widget has been renamed to OmniboxWidget. Both classes appear in the same file - omnibox.ts.

This is a pure architectural change and contains 0 functional changes.

Change-Id: I336809179de47d2c126fc913a66c0b6fda3abc22
Change-Id: I8d019b89ae928484dd442a7a62e25f47b8e44d5f
Change-Id: Id4fdc0e1e06fadc693ce5a6fd4a56e0eba11c507
@stevegolton stevegolton requested a review from primiano November 12, 2025 19:49
@stevegolton stevegolton requested a review from a team as a code owner November 12, 2025 19:49
Copy link
Member

@primiano primiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

…ctly

Change-Id: Id243276279018b6ec098f89745ac97babea73439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants