ui: Move all omnibox related logic into omnibox.ts #3643
+357
−359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a lot of the omnibox business logic is contained in the
UIMaincomponent. TheOmniboxcomponent inomnibox.tsis a purely a presentational widget.The issue is that
omnibox.tsis where one would expect to find all the omnibox logic, both business and presentational.This patch moves all the business logic into a new component called
Omnibox, and the originalOmniboxpresenational widget has been renamed toOmniboxWidget. Both classes appear in the same file -omnibox.ts.This is a pure architectural change and contains 0 functional changes.