Fix cpu_profiler broken in chrome://tracing #4234
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 5d85654 moves the registration of the perfetto::trace_processor::ProfileModule object from RegisterDefaultModules to RegisterAdditionalModules, which results in the ProtoTraceReader::ProtoTraceReader being unable to register ProfileModule, on which chrome cpu_profiler depends. This commit only reverts part of the code from 5d85654. See crbug.com/473398637
Member
|
I would like @betasheet to comment here about whether or not supporting CPU events on chrome://tracing is something we want to continue doing given that very few (if any) Chromium developers in Google are actually using chrome://tracing at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 5d85654 moves the registration of the
ProfileModuleobject fromRegisterDefaultModulestoRegisterAdditionalModules, which results in theProtoTraceReader::ProtoTraceReaderbeing unable to registerProfileModule, on which chrome cpu_profiler depends.This commit only reverts part of the code from 5d85654.
See crbug.com/473398637