tp: add new fields to view capture args #4435
Draft
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21071407228-1-ui/ui/index.html |
BogdanFloris
force-pushed
the
dev/bogdanfloris/viewcapture-new-fields
branch
2 times, most recently
from
af877f8 to
f482bc7
Compare
BogdanFloris
force-pushed
the
dev/bogdanfloris/viewcapture-new-fields
branch
from
f482bc7 to
f3293a7
Compare
PriyankaSPX
approved these changes
Jan 16, 2026
Contributor
PriyankaSPX
left a comment
PriyankaSPX
left a comment
There was a problem hiding this comment.
lgtm - please test via the diff tests in tests_viewcapture.py
| std::optional<ConstChars> ViewCaptureArgsParser::DeinternString( | ||
| uint64_t iid, | ||
| RowRef* row, | ||
| void (RowRef::*setter)(StringPool::Id)) { |
Contributor
There was a problem hiding this comment.
nit: define before DeinternString(uint64_t) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new fields to the
viewcaptureargs proto definition. It also adds makes sure that the fields can be parsed by the trace processor. See: b/436963256