ui: improve performance by reducing frequency of dom redraws #4444
+230
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state at HEAD: on every mouse move, we would trigger a full DOM redraw because it's possible the tooltip state may have been updated. This is unnecessary as most of the time when mouse move happens, we're either staying on the same hovered object *OR* (more common), we're not hovering over anything at all. Change the logic instead to only redraw the DOM when the tooltip moves. Do this by computing whether or not a dom redraw is needed on every canvas redraw. Most of the time, this will cost us ~nothing. There's also the bonus affect now of panning correctly updating the tooltip state when before it would stay stuck on the old state no matter how much you panned.
LalitMaganti
requested review from
stevegolton
and removed request for
a team
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21100018595-1-ui/ui/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state at HEAD: on every mouse move, we would trigger a full DOM
redraw because it's possible the tooltip state may have been updated.
This is unnecessary as most of the time when mouse move happens, we're
either staying on the same hovered object OR (more common), we're not
hovering over anything at all.
Fix this by keeping track of the previous hovered object and only triggering
a redraw if it really changes.
Before (notice how the dom redraw count goes up as I move my mouse):
cast.webm
After (notice how the count doesn't change):
After.screencast.webm