Skip to content

Fix null pointer dereference in FilteredRE2::RegisterDynamic #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wangziqi520
Copy link

In re2/filtered_re2.cc, the function RegisterDynamic writes to the output parameter id without first checking whether it is nullptr. If a caller passes nullptr, this leads to undefined behavior and can crash the program.

This change adds a null check for id. If id is null, the function returns false early to avoid dereferencing it.

This fixes a potential crash when using FilteredRE2 with invalid arguments.

Copy link

google-cla bot commented Jun 13, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

RE2 uses Gerrit instead of GitHub pull requests.
See the Contribute wiki page.

@github-actions github-actions bot closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant