Fix null pointer dereference in FilteredRE2::RegisterDynamic #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
re2/filtered_re2.cc
, the functionRegisterDynamic
writes to the output parameterid
without first checking whether it isnullptr
. If a caller passesnullptr
, this leads to undefined behavior and can crash the program.This change adds a null check for
id
. Ifid
is null, the function returnsfalse
early to avoid dereferencing it.This fixes a potential crash when using
FilteredRE2
with invalid arguments.